jquery / jquery/jquery-simulate
Null relatedTarget in HtmlUnit
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 172
- Forks
- 109
- PR merge metrics
- No merged PRs in 30d
Description
Very useful project!
I find that when running tests with jasmine-maven-plugin, specifically when running a headless test (which internally uses HtmlUnit for the "browser") that event.relatedTarget can be null. This throws on line 118 which tries to get event.relatedTarget.ownerDocument. The same thing works fine when testing inside a browser.
My fix is:
eventDoc = event.relatedTarget ? event.relatedTarget.ownerDocument : undefined || document;
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at line 118 in the event-handling code and reproduce the issue with a headless test using jasmine-maven-plugin and HtmlUnit. Verify that a null event.relatedTarget no longer throws, while browser-based event handling continues to work as described.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100