jquery / jquery/esprima

infrastructure: update "engines" to node>=10.9

Open
#2,056 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
7.1k
Forks
773
PR merge metrics
No merged PRs in 30d

Description

Last update of "engines" is about 1 year ago: https://github.com/jquery/esprima/commit/3d182f16403b6efad66acfd92eb46022728bee56

Now Node 10 is the oldest LTS in maintenance, the maintenance would end at 2021-04-30, which is also pretty close.

For adding support of BigInt #1988 and #2035, it's better that the environment has support of BigInt. Or the value of BigIntLiteral would be null for Node < 10.4, which increases maintenance cost.

And according to https://node.green/, Node 10.9 is the first version that fully supports ES6. We can generate ES6 code instead ES5.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the package's "engines" declaration and the configuration that controls ES5 versus ES6 output. Review the BigInt context in issues #1988 and #2035 and the linked Node compatibility references; done means the supported minimum is Node 10.9 and the generated output uses ES6 as intended.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
build-system
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.