jquery / jquery/esprima

Support JSX fragments

Open
#2,020 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
7.1k
Forks
772
PR merge metrics
No merged PRs in 30d

Description

Steps to reproduce
esprima.parse('<></>', { jsx: true })
Expected output
// excludes location information for brevity
{
  "type": "Program",
  "body": [
    {
      "type": "ExpressionStatement",
      "expression": {
        "type": "JSXFragment",
        "openingFragment": {
          "type": "JSXOpeningFragment"
        },
        "closingFragment": {
          "type": "JSXClosingFragment"
        }
      }
    }
  ],
  "sourceType": "module"
}
Actual output

This exception is thrown: Line 1: Unexpected token >

Relevant references

Looks like jsx-parser.ts would have to change here, and possibly elsewhere. This syntax works fine in @babel/parser and acorn.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the JSX parsing logic in src/jsx-parser.ts at the referenced location, and reproduce the issue using esprima.parse('<></>', { jsx: true }). Compare the result with the expected JSXFragment AST in the issue. Done means this input parses successfully and produces the shown openingFragment and closingFragment nodes.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
compilers
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.