jquery / jquery/esprima

tokenizer is missing necessary new line character

Open
#1,976 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
7.1k
Forks
773
PR merge metrics
No merged PRs in 30d

Description

Steps to reproduce
esprima.tokenize('return 0')

esprima.tokenize('return\n 0')
Expected output

the second token list should contains a new line character

Actual output

two result are the same

Relevant references

N/A

I'm using the result token list to construct the code again, but the new line character is missing. This could has some affect on ASI, which could leads to different code logic.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the esprima.tokenize entry point and reproduce the two snippets from the issue to compare their token lists. Trace how line breaks are handled, then add coverage showing that the second input preserves the newline distinction and that the reconstructed code does not lose it.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.