jquery / jquery/esprima

range is incorrect

Open
#1,963 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
7.1k
Forks
772
PR merge metrics
No merged PRs in 30d

Description

I have some code here: https://github.com/ariovistus/esprima-bug

test.js uses esprima 4.0.1 to parse tok.js and outputs

define "urijs" 2250,2265

which is the position of the last part of tok.js, define("urijs"), as reported by esprima. but it is wrong, the actual position should be 2272

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running test.js from the linked ariovistus/esprima-bug reproduction against esprima 4.0.1 and comparing the reported range for tok.js with the actual source position. Trace how the parser computes the range for the final define("urijs") segment, then verify the result is 2272 and preserve the case in a regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.