jquery / jquery/esprima

Doesn't throw on eval /arguments in destructuring binding

Open
#1,881 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
7.1k
Forks
773
PR merge metrics
No merged PRs in 30d

Description

Specs says: "It is a Syntax Error if IsValidSimpleAssignmentTarget of IdentifierReference is false"

Steps to reproduce
esprima.parse('"use strict"; 1, { arguments } = [];')
Expected output

Syntax error

Actual output

Parses invalid AST

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the esprima.parse example from the issue and inspect the parser entry points handling destructuring bindings and strict-mode validation. Done means the same input reports a syntax error instead of producing an AST, with coverage for this reproduction added where the parser's existing tests are located.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.