Doesn't fail on invalid unicode escape sequences in export / import
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 7.1k
- Forks
- 773
- PR merge metrics
- No merged PRs in 30d
Description
This is for both import and export. And here is one TC-39 reference showing the issue.
Steps to reproduce
esprima.parse('export {a \\u0061s b} from "./foo.js";')
Expected output
Should throw
Actual output
Outputs and AST
Relevant references
ShiftJS and Acorn also outputs an invalid AST. However V8 throws correctly
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the esprima.parse reproduction and the linked TC-39 export test, then trace the import and export parsing paths that accept the escaped specifier. Done means invalid Unicode escape sequences in both import and export forms throw instead of producing an AST, with coverage for the reported case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100