jquery / jquery/esprima

Parses invalid func param with non-simple parameter lists

Open
#1,864 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
7.1k
Forks
773
PR merge metrics
No merged PRs in 30d

Description

Doesn't fail correctly with non-simple parameter lists.

Steps to reproduce
esprima.parse('function f([x] = [1]) { "use strict" }')
Expected output

Should fail

Actual output

Passes

Relevant references

Works as expected in Acorn, Shift and others

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue through the esprima.parse entry point with the function declaration shown in the report, then trace how non-simple parameter lists are validated in strict mode. Done means the input is rejected as expected and a regression test covers this case.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.