jquery / jquery/esprima

Parses Invalid regular expressions flag

Open
#1,863 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
7.1k
Forks
773
PR merge metrics
No merged PRs in 30d

Description

As far as I know, only g, i , m, u, y are allowed as regular expression flags. Esprima allowes everything.

Steps to reproduce
esprima.parse(`/(?:)/esprima_reg_exp_should_disallow_this`)
Expected output

Should fail

Actual output

Parses correctly

Relevant references

Acorn, Shift and others handle this correctly

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the esprima.parse example from the issue and locate the regular-expression parsing entry point that accepts the esprima_reg_exp_should_disallow_this flags. Compare the behavior with Acorn or Shift, then verify that invalid flags are rejected while the listed valid flags continue to parse correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.