jquery / jquery/esprima

Parsing HTML-like comments after multiline comment

Open
#1,828 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

defect
Dominant language
TypeScript
Stars
7.1k
Forks
773
PR merge metrics
No merged PRs in 30d

Description

Using http://esprima.org/demo/validate.html I found that Esprima doesn't follow the ECMAScript spec related to HTML-like comments: https://www.ecma-international.org/ecma-262/6.0/#sec-html-like-comments.

 
ident /* multiline
comment */ -->

outputs Error: Line 3: Unexpected token >, which is incorrect. It should parse a MultiLineComment as per the spec link above.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the snippet in the Esprima validation demo, then read the ECMAScript HTML-like comments section linked in the issue. Trace how the parser handles the multiline comment followed by -->; done means the example parses the trailing sequence as a MultiLineComment instead of reporting an unexpected > token.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.