jquery-form / jquery-form/form

Enable AND disable the `consistent-this` rule

Open
#553 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature help wanted
Dominant language
JavaScript
Stars
5.1k
Forks
2.1k
PR merge metrics
No merged PRs in 30d

Description

https://github.com/jquery-form/form/blob/master/src/jquery.form.js#L138

This line causes problems if we are concatenating with several other vendor pieces of code.

The only way to resolve this is to use dist/jquery.form.min.js, however it'd be great if we had a non-minified version in the dist folder as well 👍

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/jquery.form.js around line 138 and inspect how the distribution files are produced, especially dist/jquery.form.min.js. Clarify whether the requested result is a non-minified dist file, changing the consistent-this rule, or both; done should match the agreed behavior without causing conflicts when concatenated with other vendor code.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.