jquery-form / jquery-form/form
Incompatible with jQuery 3 slim build
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 5.1k
- Forks
- 2.1k
- PR merge metrics
- No merged PRs in 30d
Description
Hey there,
I've got the problem with this package while using Jquery 3.2.1.
function ajaxForm is giving me an error: Cannot read property 'success' of undefined.
Someone on stackoverflow explained it there:
https://stackoverflow.com/questions/45655409/website-using-jquery-form-version-4-2-2-and-jquery-3-
jQuery v3 introduces a lot of sweeping chances: one of which is the removal of the jqXHR.success() callback (it has been deprecated since v1.8, but many authors don't seem to bother to migrate/update). The plugin is obviously not updated to listen to resolution of promise using the jqXHR.done() callback.
Is there any chance to fix this problem?
Thank you ;)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the ajaxForm implementation and reproduce the reported error with jQuery 3.2.1 and its slim build. Trace the jqXHR callback handling; done means the error no longer occurs and the form callback works with the supported jQuery build.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, jquery
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100