jpuri / jpuri/draftjs-to-html

method getStyleTagSectionMarkup(styleSection) calls addInlineStyleMarkup incorrectly

Open
#57 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
325
Forks
139
PR merge metrics
No merged PRs in 30d

Description

In Method getStyleTagSectionMarkup(styleSection) addInlineStyleMarkup is called with 3 parameters insted of 2

function getStyleTagSectionMarkup(styleSection) {
    var styles = styleSection.styles,
        text = styleSection.text;

    var content = getSectionText(text);
    forEach(styles, function (style, value) {
        content = addInlineStyleMarkup(style, content, value);
    });
    return content;
}
function addInlineStyleMarkup(style, content) {
    if (style === 'BOLD') {
        return '<strong>' + content + '</strong>';
    } else if (style === 'ITALIC') {
        return '<em>' + content + '</em>';
    } else if (style === 'UNDERLINE') {
        return '<ins>' + content + '</ins>';
    } else if (style === 'STRIKETHROUGH') {
        return '<del>' + content + '</del>';
    } else if (style === 'CODE') {
        return '<code>' + content + '</code>';
    } else if (style === 'SUPERSCRIPT') {
        return '<sup>' + content + '</sup>';
    } else if (style === 'SUBSCRIPT') {
        return '<sub>' + content + '</sub>';
    }
    return content;
}

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at getStyleTagSectionMarkup(styleSection) and compare its addInlineStyleMarkup call with the shown two-parameter function signature. Check how the style markup is generated for each style, then confirm the call uses the intended arguments and that the resulting HTML remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.