jpuri / jpuri/draftjs-to-html

customEntityTransform is not applied if entity is within bullet list

Open
#103 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
325
Forks
139
PR merge metrics
No merged PRs in 30d

Description

I bumped into this recently, because I wanted to override with customEntityTransform that every link included is opened into a new tab. Somehow it seems that customEntityTransform is not taken into account if entity is within a bullet list.

Is that intended? Id be more than happy to dive into this next week and do a pr, if there are any active maintainers.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the reported case with customEntityTransform applied to an entity inside a bullet list, then trace the bullet-list conversion path in the repository. Done means the transform is applied consistently to links inside bullet-list items, with a regression test covering that case.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.