jpsim / jpsim/SourceKitten

Interest in returning JSON from send?

Open
#302 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
2.4k
Forks
237
PR merge metrics
No merged PRs in 30d

Description

I've created a fork of SourceKitten so that I can return JSON (read: Any) from failableSend(). I'm wondering what interest the project maintainers would have for accepting such a patch/change?

This is the change I'm specifically talking about. Obviously I'd be willing to write some tests and/or rename the method. This was just quick-n-dirty to see what such a method would look like.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the linked SourceKitten fork commit and the existing failableSend() API. Confirm the intended JSON/Any return behavior and method naming with maintainers, then add the requested tests and use them to define when the change is complete.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
api
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.