jpsim / jpsim/JPSThumbnailAnnotation
disclosureBlock on thumbnail is difficult to use (not very MVC)
Nobody has claimed this yet.
- Dominant language
- Objective-C
- Stars
- 474
- Forks
- 77
- PR merge metrics
- No merged PRs in 30d
Description
we need to display a detail controller when user tap on the disclosure button. Since the disclosureBlock is defined in thumbnail (model), which doesn't have access to the views JPSThumbnailAnnotationView nor MKMapView and can't be override without changing the thumbnail, what is the best way to deal with this common use case?
can the JPSThumbnailAnnotationView invoke map.delegate's calloutDidTap callback if the block is nil? Otherwise expose the block on JPSThumbnailAnnotationView so we can override it ourselves? thoughts?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing disclosureBlock from JPSThumbnailAnnotationView to the thumbnail model, then inspect how MKMapView delegates handle callout taps. Compare the proposed delegate callback and view-level block approaches, and define which API should support opening a detail controller without changing the thumbnail. Done means the chosen behavior is specified and covered by the relevant project tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- objective-c
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100