jprichardson / jprichardson/node-google

Can we have option for http and https?

Open
#40 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
456
Forks
115
PR merge metrics
No merged PRs in 30d

Description

Using this inside company firewall may not work because I cannot go to https://www.google.com.

Can we have option for http here?

var URL = 'https://www.google.%s/search?hl=%s&q=%s&start=%s&sa=N&num=%s&ie=UTF-8&oe=UTF-8&gws_rd=ssl'

https://github.com/jprichardson/node-google/blob/faf57d24bde301a7249d16a1c1589c5506a56ccf/lib/google.js#L11

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in lib/google.js at the URL definition linked in the issue and inspect how the module exposes its search options. Add a way to choose HTTP or HTTPS while preserving the current behavior by default, then verify that both protocol choices produce the expected Google URL.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
backend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.