jprichardson / jprichardson/node-github-download

Cannot download to destination on different partition or device (Linux)

Open
#18 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
77
Forks
31
PR merge metrics
No merged PRs in 30d

Description

On Linux, this package will error out if you attempt to download to a directory on a different partition or device from your working directory.

Here's an example of the error message:

EXDEV: cross-device link not permitted, rename '/home/sniffnoy/truffle/bare/1595361480018-8246913923470209/bare-box-master' -> '/tmp/tmp-27587-bq1OIiU3jrtC/box'

(In this case I was attempting to download to a temporary directory, as you can see.)

The reason for this is that this package works by first downloading to a temporary directory in place, then renaming it to the destination. However, on Linux, renames are not permitted across different devices (such as different partitions). This makes using the package quite difficult.

In addition, the package does not clean up the temporary files it created should the rename fail, for what it's worth.

Thank you!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the temporary-directory download and final rename path in the package, then reproduce the reported EXDEV error with a destination on another device or partition. Done means downloads succeed across devices and temporary files are cleaned up when the operation fails.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.