jprichardson / jprichardson/node-github-download
Throws an error for urls with branches containing '/'
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 77
- Forks
- 31
- PR merge metrics
- No merged PRs in 30d
Description
When trying to download a url that contains a branch ref with a '/' it throws an error like the following:
Error: ENOENT: no such file or directory, open '/Users/.../.../1549913237088-42743833620309557/bare-box-truffle/test-branch.zip'
To duplicate try and use the library to download the following url: https://github.com/truffle-box/bare-box#truffle/test-branch
Is this just a limitation of this package or do you think you will support this in the future?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the failure by downloading https://github.com/truffle-box/bare-box#truffle/test-branch, then trace how the URL's branch ref is converted into a local archive path. Done means the download completes successfully for branch names containing '/'; add or update a regression test if the repository's existing test setup identifies one.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100