jpillora / jpillora/node-ssh-http-agent

Should pass 'debug' parammeter like the http factory method

Open
#1 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
6
Forks
2
PR merge metrics
No merged PRs in 30d

Description

https://github.com/jpillora/node-ssh-http-agent/blob/5dec3f93ab9147386f048c984e3eb518ac59a116/agent.js#L294

As debug is not passed as a parammeter, it takes the global debug, which is a symbol.

Adding the `debug param fixes the issue.

sshAgent.https = function (via, debug) {

Great library! saved my day 👍

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open agent.js at the linked line around 294 and compare sshAgent.https with the HTTP factory method's parameters. Ensure the debug parameter is handled there, then verify that the issue's reported global debug behavior is fixed.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
backend, networking
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.