jpillora / jpillora/node-edit-google-spreadsheet
getValues option not getting passed correctly to util.gcell2cell (spreadsheet.js: 510)
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 301
- Forks
- 98
- PR merge metrics
- No merged PRs in 30d
Description
this line in spreadsheet.js (510):
rows[r][c] = util.gcell2cell(cell, options.getValues, _this.opts.useCellTextValues);
the second parameter should be:
_this.opts.getValues
corrected line:
rows[r][c] = util.gcell2cell(cell, _this.opts.getValues, _this.opts.useCellTextValues);
I love this module. Thanks!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in spreadsheet.js at line 510 and compare the second argument passed to util.gcell2cell with the option source described in the issue. Done means the call passes _this.opts.getValues while preserving the other argument.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100