chisel crash randomly
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 16.6k
- Forks
- 1.6k
- PR merge metrics
- No merged PRs in 30d
Description
version: 1.8.1 linux amd64
chisel server -p 1111
chisel client 4.5.6.7:1111 1111:2222/udp
Client connect to server through a https proxy, and the network may not be stable.
panic: sync: WaitGroup is reused before previous Wait has returned
goroutine 13 [running]:
sync.(*WaitGroup).Wait(0x0?)
sync/waitgroup.go:141 +0x85
github.com/jpillora/chisel/share/tunnel.(*waitGroup).Wait(...)
github.com/jpillora/chisel/share/tunnel/wg.go:31
github.com/jpillora/chisel/share/tunnel.(*Tunnel).activatingConnWait.func1()
github.com/jpillora/chisel/share/tunnel/tunnel.go:137 +0x2c
created by github.com/jpillora/chisel/share/tunnel.(*Tunnel).activatingConnWait
github.com/jpillora/chisel/share/tunnel/tunnel.go:136 +0x85
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with share/tunnel/wg.go and share/tunnel/tunnel.go at the WaitGroup and activatingConnWait stack frames. Reproduce the server and client commands through an HTTPS proxy with an unstable network, then verify that reconnecting no longer triggers the WaitGroup reuse panic.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100