Set ServerName (SNI).
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 16.6k
- Forks
- 1.6k
- PR merge metrics
- No merged PRs in 30d
Description
I think there's a pretty strong argument for setting the ServerName (SNI) to the value of --hostname.
It's pretty much standard to set the ServerName in the TLS ClientHello when a hostname is requested. Regardless, being able to set the SNI is something that's been requested a few times.
The changes are straightforward, won't require a new command line switch and don't appear to be beyond the scope of things (especially seeing as we have --hostname already)
I've submitted a pull request here: https://github.com/jpillora/chisel/pull/376
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the existing --hostname handling and the pull request linked from the issue, PR #376. Trace how the TLS ClientHello is created and verify that the requested hostname is used for ServerName (SNI); done means the behavior is implemented without a new command-line switch and is covered by the project's relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 20/100