jpillora / jpillora/base64-encoder
GitHub link image not shown, HTML validity (missing doctype)
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 262
- Forks
- 79
- PR merge metrics
- No merged PRs in 30d
Description
Thanks, just the tool I was looking for (client-side, JS only) to embed my favicon.
With Firefox 49.0.1 on Windows the image https://s3.amazonaws.com/github/ribbons/forkme_left_darkblue_121621.png is reduced to an invisible 1x1 image in cache, although if I (re-)load this file directly, it is properly displayed.
This seems to be caused by the img tag not being closed (https://github.com/jpillora/base64-encoder/blob/gh-pages/index.html#L58).
The validators don't catch this at first because the HTML is slightly off:
Auto-detect type:
https://validator.w3.org/check?uri=http%3A%2F%2Fjpillora.com%2Fbase64-encoder%2F&charset=%28detect+automatically%29&doctype=Inline&group=0
HTML5:
https://validator.w3.org/nu/?doc=http%3A%2F%2Fjpillora.com%2Fbase64-encoder%2F
So you might want to add <!DOCTYPE html>.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open gh-pages/index.html and inspect the image tag around line 58, then review the page declaration at the top. Check the page in Firefox and run the linked W3C HTML validators. Done means the GitHub ribbon displays at its intended size and the page passes HTML5 validation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100