jpadilla / jpadilla/mandrill-inbound-python

Question on inbound messages

Open
#8 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
18
Forks
7
PR merge metrics
No merged PRs in 30d

Description

Mandrill sends an array of objects, I'm wondering if there are cases where you get multiple messages per event?

It looks like the code assumes the first item in the returned array: https://github.com/jpadilla/mandrill-inbound-python/blob/master/mandrill_inbound/__init__.py#L18

Would it be accurate to change the example from:

json_data = json.loads(open('./tests/fixtures/valid_http_post.json').read())
inbound = MandrillInbound(source=json_data)

to

json_data = json.loads(open('./tests/fixtures/valid_http_post.json').read())
inbound = MandrillInbound(source=json_data[0])

?

Thanks, great helper library!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review mandrill_inbound/init.py at line 18 and tests/fixtures/valid_http_post.json to confirm the inbound payload shape and how the example currently passes it to MandrillInbound. Done means the example and library expectations agree about array versus object input, with the fixture-based behavior verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.