joypixels / joypixels/emoji-toolkit-android

Ascii matching by default unintentionally?

Open
#5 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
6
Forks
3
PR merge metrics
No merged PRs in 30d

Description

Hi, I was just wondering if there was a reason the default value for matching ascii is `true` in the Android tool kit yet `false` in the others? Not a huge issue as it can be changed, but I ran into an issue due to this and figured maybe it was unintended.

https://github.com/joypixels/emoji-toolkit-android/blob/e2824d13e7ebaf05e3710bca163a29e00d31e109/tools/src/main/java/com/joypixels/tools/Client.java#L29

https://github.com/joypixels/emoji-toolkit-ios/blob/dea870df5ca532d8ae8af97762070721205946d0/JoyPixels/JoyPixels/Client.swift#L13

https://github.com/joypixels/emoji-toolkit/blob/386935f8b715f76dd0bcdbc3bee54551a0023064/lib/php/src/Client.php#L11

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.