jossmac / jossmac/react-images

Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes'.

Open
#406 1 comment 4 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.3k
Forks
433
PR merge metrics
No merged PRs in 30d

Description

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used [patch-package](https://github.com/ds300/patch-package) to patch `react-images@1.2.0-beta.7` for the project I'm working on.

Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes'.

Here is the diff that solved my problem:

```diff
diff --git a/node_modules/react-images/index.d.ts b/node_modules/react-images/index.d.ts
index 3f98829..34b376f 100755
--- a/node_modules/react-images/index.d.ts
+++ b/node_modules/react-images/index.d.ts
@@ -138,7 +138,7 @@ declare const Carousel: React.ComponentType

declare const Modal: React.ComponentType

-declare const ModalGateway: React.ComponentType<{}>
+declare const ModalGateway: React.ComponentType<{children:any}>

export default Carousel
export { Modal, ModalGateway }
```

This issue body was [partially generated by patch-package](https://github.com/ds300/patch-package/issues/296).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.