jossmac / jossmac/react-images

Add option to translate footer ({activeView} of {totalViews})

Open
#356 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.3k
Forks
433
PR merge metrics
No merged PRs in 30d

Description

**Steps to reproduce the behavior:**
/

**Expected behavior:**
It would be nice to be able to change the footer text (currently hardcoded: `{activeView} of {totalViews}`) without replacing the whole `Footer` component.
https://github.com/jossmac/react-images/blob/89ba2786959e62fc91a639e09da4498bd79dd7c3/src/components/Footer.js#L112-L117

**Actual behavior:**
The only option to change the text (as far as I can see) is to override the Footer component. It would be more convenient to have it included in the already existing `formatters` object:
https://github.com/jossmac/react-images/blob/89ba2786959e62fc91a639e09da4498bd79dd7c3/src/formatters.js#L66-L74

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.