jossmac / jossmac/react-images

closeOnBackdropClick doesn't work with custom View

Open
#350 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.3k
Forks
433
PR merge metrics
No merged PRs in 30d

Description

Hi, first of all thanks for this great lib :hugs:

So it's not explained in the docs that the `closeOnBackdropClick` needs the viewer's container and viewer's image to have some classes.

Without this knowledge, when using a custom `View` component, the `closeOnBackdropClick` doesn't work.

It would be great to explain this on the docs and provide those classes in the `innerProps` or so

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.