jossmac / jossmac/react-images

Image flicker effect on Safari

Open
#287 16 comments 3 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.3k
Forks
433
PR merge metrics
No merged PRs in 30d

Description

First of all, thank you for the amazing work on react-images. I've been happily using the library for some time now. I've just noticed that the v1 was released and decided to give it a go. However, came across what seemed to be a bug (or two separate bugs), that are at least perceivable on Safari.

**Steps to reproduce the behaviour:**
1. Open http://jossmac.github.io/react-images on Safari
2. Clicking on images other than the first one, sometimes yields a jumpy effect, where the very first image is rendered and then replaced by the clicked image. I could reproduce it consistently on Safari 12.0.2. I was not able to perceive the issue on Chrome, however, I could notice it slightly on Firefox, though, not nearly as noticeable as on Safari.
3. When clearing browser cache in Safari (cmd+alt+e), reloading the page and immediately clicking on an imagine, sometimes yields a thumbnail view, which does not seem like the expected behaviour. I'm not sure if it's related with browser cache and unlike the jumpy image effect, this one I'm not able to reproduce consistently every time, but it does happen sometimes.

**Expected behaviour:**
1. No jumpy effect when clicking an image
2. No thumbnail view when clicking an image after clearing browser cache

**Actual behavior:**
1. Jumpy effect when clicking an image
2. Sometimes odd thumbnail view appears

In case someone is having difficulty reproducing the above mentioned issues, I've captured a screen recording, which is available here https://youtu.be/6YzoDd2fJao.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.