joshwnj / joshwnj/react-visibility-sensor

VisibilitySensor onChange triggers on render

Open
#78 7 comments 7 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
2.3k
Forks
192
PR merge metrics
No merged PRs in 30d

Description

My component looks something like this
```
class MyComponent extends Component {
onChange(isVisible){
this.setState({visCount : this.state.visCount + 1}) //
}
render(){
return

this.onChange(v)} />

}
}
```
The issue is `onChange` is getting triggered on every render, which then triggers another render so visCount keep auto-incrementing. Am I doing something wrong here? How are you supposed to use setState in onChange?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.