joshwnj / joshwnj/react-visibility-sensor

Module not found: Error: Can't resolve 'React' in '/home/capaj/project/node_modules/react-visibility-sensor/dist'

Open
#148 15 comments 5 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.3k
Forks
192
PR merge metrics
No merged PRs in 30d

Description

I have webpack 4 and react-visibility-sensor 5.0.2
and when I import like this:
`import VisibilitySensor from "react-visibility-sensor"`
I get
```
ERROR in ../node_modules/react-visibility-sensor/dist/visibility-sensor.js
Module not found: Error: Can't resolve 'React' in '/home/capaj/git_projects/looop/project-alpha/node_modules/react-visibility-sensor/dist'
@ ../node_modules/react-visibility-sensor/dist/visibility-sensor.js 4:286-324
@ ./src/pages/student-topic-detail-page/StudentTopicDetailPage.tsx
@ ./src/components/LooopRoutes.tsx
@ ./src/components/App.js
@ ./src/app/app.js
@ ./src/index/index.js
@ multi webpack-dev-server/client?http://localhost:4001 webpack/hot/dev-server ./src/index/index

ERROR in ../node_modules/react-visibility-sensor/dist/visibility-sensor.js
Module not found: Error: Can't resolve 'ReactDOM' in '/home/capaj/git_projects/looop/project-alpha/node_modules/react-visibility-sensor/dist'
@ ../node_modules/react-visibility-sensor/dist/visibility-sensor.js 4:286-324
@ ./src/pages/student-topic-detail-page/StudentTopicDetailPage.tsx
@ ./src/components/LooopRoutes.tsx
@ ./src/components/App.js
@ ./src/app/app.js
@ ./src/index/index.js
@ multi webpack-dev-server/client?http://localhost:4001 webpack/hot/dev-server ./src/index/index
```
when I change to import the source file:
`import VisibilitySensor from 'react-visibility-sensor/visibility-sensor'`

it works great.

The webpack thingy seems to think I the app run in an UMD loader and hence it tries to load deps from globals.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.