joshwcomeau / joshwcomeau/react-flip-move

Style removal on using accordionVertical animation

Open
#196 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
4.1k
Forks
250
PR merge metrics
No merged PRs in 30d

Description

The style attribute should be removed after the animation end when using the accordionVertical animation.
although the style remain with the property `transform-origin` with the value of `"center top 0px"`

It's not gonna make any problem but I think it must be more clear if you remove the style attribute at all.

Thank you.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the accordionVertical animation and its animation-end cleanup in the repository. Reproduce the animation and verify that the style attribute, including transform-origin, is removed after it finishes.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.