joshuaulrich / joshuaulrich/quantmod
Remove S4 classes
- Dominant language
- R
- Stars
- 906
- Forks
- 233
- PR merge metrics
- No merged PRs in 30d
Description
The `setOldClass("xts")` and `setOldClass("zoo")` calls in quantmod cause issues if other packages need to define those classes as well. For example, see https://github.com/edzer/spacetime/issues/35, and a [StackOverflow question](https://stackoverflow.com/q/44295792/271616) I answered a couple years ago.
I mentioned these to @jaryan and he would prefer to remove all the S4 classes from quantmod.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by locating the setOldClass("xts") and setOldClass("zoo") calls in quantmod, then inspect the package for the other S4 classes mentioned in the issue and their usages. The work is done when quantmod no longer defines those S4 classes and its existing checks or tests still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100