joshsoftware / joshsoftware/sso-devise-omniauth-provider

AccessToken expiry...

Open
#7 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Ruby
Stars
248
Forks
72
PR merge metrics
No merged PRs in 30d

Description

In the AuthController, when a client is granted an access token (an AccessGrant instance) and `start_expiry_period!` is called, an expiry of two days is stored in the database. However the AuthController then goes on to send an `expires_in` of `Devise.timeout_in` to the client, which in my case seems to be 30 minutes.

Unless I'm mistaken (which is quite possible!), shouldn't the `expires_in` be read from the AccessGrant, or both of theses read from Devise.timeout_in?

If you have a preference for which, I'll put in a pull request.

Regards,

Gavin

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.