josephg / josephg/fdb-tuple

Potential performance improvement

Open
#5 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
14
Forks
3
PR merge metrics
No merged PRs in 30d

Description

Hi @josephg , is there any reason to allocate new buffer on every encode/decode call?
https://github.com/josephg/fdb-tuple/blob/master/lib/index.ts#L153

The code looks synchronous and in node's single threaded environment, one large (eg 10k) buffer should reduce allocations to near zero and increase performance dramatically. I'm wondering if I might be missing something.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.