josephg / josephg/ShareJS

JSON API: provide full API from SubDoc

Open
#81 3 comments 0 reactions 0 assignees View on GitHub
bug implement me
Dominant language
JavaScript
Stars
5k
Forks
454
PR merge metrics
No merged PRs in 30d

Description

The following works as expected for text docs, but breaks on json docs.

``` javascript
doc instanceof sharejs.Doc //true
doc.on('remoteop', fn)
doc.removeListener('remoteop', fn)
```

The JSON API provides a `removeListener` of its own that gets mixed in to Doc, but no `on`. (`SubDoc`'s do have `on` however.) This causes removeListener to not remove the listener.

Thoughts on the best way to proceed?
- change the name of removeListener in the json api?
- provide an 'on' that does the correct thing into the json api?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.