josephg / josephg/ShareJS

this.stream.read() is undefined

Open
#383 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
5k
Forks
454
PR merge metrics
No merged PRs in 30d

Description

When i pass my stream object to shareJS, it throws error. But i'm totally sure that it is normal stream. Streams just don't have read() method

This is example using faye-websocket implementation

``` coffee
http = require 'http'
share = require 'share'
WebSocket = require 'faye-websocket'

server = http.createServer()
server.on 'upgrade', (request, socket, body) ->
if WebSocket.isWebSocket(request)
ws = new WebSocket(request, socket, body)
shareClient = share.server.createClient(backend: backend)
shareClient.listen(ws.pipe(ws))
```

I also try to pass in stream from SockJS, having the same error.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.