josephg / josephg/ShareJS

JSON: Are we removing string paths?

Open
#247 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
5k
Forks
454
PR merge metrics
No merged PRs in 30d

Description

@dgreisen this normalizePath function breaks string based paths:
https://github.com/share/ShareJS/blob/master/lib/types/json-api.js#L58

Are we intentionally deprecating context.get('foo') and requiring people to write context.get(['foo'])? If so this should throw an error. Otherwise we can delete normalizePath, Array#concat automatically wraps things in an array when necessary.

Currently this creates a bug, appending undefined to the path array.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.