josephg / josephg/ShareJS

json.removeListener overrides MicroEvent.removeListener

Open
#193 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
5k
Forks
454
PR merge metrics
No merged PRs in 30d

Description

Trying to solve a load issue where (in my case snapshot is initially _null_ and I wait for the first change made server-side) When I started using the **doc.on('once')** event, I found it never getting removed. Instead the _json.removeListener_ is called and the event lingers.

Renaming _MicroEvent.removeListener_ resolved this for me.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.