josephg / josephg/Chipmunk-js

RotaryLimitJoint.prototype.getImpulse is missing the 'joint' argument

Open
#38 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
539
Forks
59
PR merge metrics
No merged PRs in 30d

Description

In https://github.com/slembcke/Chipmunk2D/blob/dbc983e3f3f2f7269aca8d21ba64085c00130172/src/cpRotaryLimitJoint.c
getImpulse takes a 'joint' argument.

This is missing, here:
https://github.com/josephg/Chipmunk-js/blob/master/cp.js#L5913

Contributor guide

No contributing guide indexed for this repository

Research direction

Open cp.js around line 5913 and compare RotaryLimitJoint.prototype.getImpulse with the referenced Chipmunk2D implementation. The issue is complete when the missing joint argument is present in the JavaScript method signature.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
game-dev
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.