josdejong / josdejong/jsoneditor
Icons feature request
Open
feature
- Dominant language
- JavaScript
- Stars
- 12.3k
- Forks
- 2.1k
- PR merge metrics
- No merged PRs in 30d
Description
Hi.
Plugin uses old image sprite technique that has lots of flexibility blockers. For example, if you want to change colors for icons you need to change SVG sprite. Also, issues because of sprite URL https://github.com/josdejong/jsoneditor/issues/675
I think icons could be develop using inline SVG icons approach https://css-tricks.com/cascading-svg-fill-color/
It would be more flexible, accessible and you will remove link to sprint from CSS that is point on lots issues
Contributor guide
Assessment
This issue has not been assessed yet.