jorgensd / jorgensd/dolfinx-tutorial

Discrepancy between Navier-Stokes into and first example

Open
#288 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
166
Forks
89
Avg merge
3h 25m
Merged PRs (30d)
2

Description

In the Navier-Stokes introductory page, an intermediate step is described [here](https://jsdokken.com/dolfinx-tutorial/chapter2/navierstokes.html#equation-ipcs-one). By the definition of $u^{n+\frac12} = \frac12 (u^{n}+u^{n+1})$, the equation depends on $u^\ast$ as well as $u^{n+1}$. In the [first example problem](https://jsdokken.com/dolfinx-tutorial/chapter2/ns_code1.html), it seems $u^\ast$ is implicitly assumed to be the same as $u^{n+1}$:
```py
# previously
U = 0.5 * (u_n + u)
# ...
p_n = Function(Q)
p_n.name = "p_n"
F1 = rho * dot((u - u_n) / k, v) * dx # here
F1 += rho * dot(dot(u_n, nabla_grad(u_n)), v) * dx
F1 += inner(sigma(U, p_n), epsilon(v)) * dx
F1 += dot(p_n * n, v) * ds - dot(mu * nabla_grad(U) * n, v) * ds
F1 -= dot(f, v) * dx
a1 = form(lhs(F1))
L1 = form(rhs(F1))
```
I believe this discrepancy is resolved by instead defining:
$u^{n+\frac12} := \frac12 (u^{n}+u^{*})$

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.