jorgensd / jorgensd/FEniCS23-tutorial

Some comments

Open
#2 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
9
Forks
1
PR merge metrics
No merged PRs in 30d

Description

1. Add function expressions for the Lagrange element basis functions shown in "An introduction to the unified form language"? Would make it clearer that the planes in the figure "First order Lagrange basis functions" are spanned by the basis functions
2. When printing the basix tabulations, specify what the array values printed are? (if I understood correctly they are the function values of the basis functions in the tabulated points?)
3. In the introduction under "The computational domain" it says "For now, we don’t know if we are solving the Poisson equation on..." but the impression from the start is that we are to solve a projection problem?
4. The "Code generation" chapter begins with "All the code in the previous section is Python code symbolically describing the variational form of the projection. This is why we in FEniCS rely on code generation." It's not entirely clear why we need code generation, is it because the code is symbolic and we need to convert the code to something we can evaluate?
5. Transition from "Code generation" chapter to "Mesh generation" is somewhat abrupt, but you might be planning to add something? Would suffice to e.g. just add a comment to what is being printed when you're inspecting the `introduction.c` code.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.