Do not compare floats using equality.
Open
- Dominant language
- Reason
- Stars
- 389
- Forks
- 25
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/jordwalke/flex/blob/fd0257ec12617f5d8c12752ce0ec690f15d249fb/src/lib/Layout.re#L75
Tradeoff: Any kind of specialized float comparison that uses an epsilon might be slower overall.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by reading src/lib/Layout.re at line 75 and trace how the float comparison affects layout calculations. Determine an acceptable comparison approach while considering the stated performance tradeoff; done means the equality comparison is removed without introducing a layout regression.
Written by the indexing model from the issue text.
Assessment
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100