joomla / joomla/jissues

Labels Bug?

Open
#910 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug GitHub sync
Dominant language
PHP
Stars
73
Forks
79
Avg merge
1d 5h
Merged PRs (30d)
8

Description

https://github.com/joomla/jissues/blob/master/src/App/Tracker/Model/IssueModel.php#L538-L550

With this block of code and the table's store method being called and told to update null values, wouldn't this essentially mean that if something passes a data array to be saved without including the labels key that existing labels would be overwritten? And if that's the case, is this partly responsible for #898 happening?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/App/Tracker/Model/IssueModel.php at lines 538-550 and trace the table store call when the labels key is absent from the data array. Reproduce that save path and compare its behavior with issue #898; done means confirming whether existing labels are overwritten and documenting or correcting the identified behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.