jonkemp / jonkemp/inline-css

DOCTYPE statement with external identifier getting trimmed to `<DOCTYPE html>`

Open
#130 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
438
Forks
77
PR merge metrics
No merged PRs in 30d

Description

It seems that `inline-css` is truncating the "external identifier" part of DOCTYPE.

Consider this example

```javascript
const inlineCss = require('inline-css')
inlineCss(
'',
{ url:'file://test.html' }
).then(console.debug)
//
```

Versions:
```
Node: v20.12.0
inline-css: 4.0.2
```

While browsers ignore most parts of DOCTYPE, this may be relevant for emails. I suspect this comes from Cheerio, but since `inline-css` puts more focus on emails, figured it may be more relevant to ask here. Is this the expected behavior?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.