When using a 'wrapper', the data passed in 'onGotFirstAd' is not updated
- Dominant language
- JavaScript
- Stars
- 58
- Forks
- 19
- PR merge metrics
- No merged PRs in 30d
Description
Inside `onGotFirstAd`, when calling `oaf.call(that, that);`, the `that` argument is passed instead of `ads`. As far as I understand it should be:
``` js
(function(ad, allowPods, that) {
onGotFirstAd = function(ads) {
ad.onLoaded(ads, allowPods);
if (that.onAdsAvailable) {
var oaf = that.onAdsAvailable;
that.onAdsAvailable = null;
oaf.call(that, ads);//instead of oaf.call(that, that);
}
};
})(ad, allowPods, that);
```
while debugging the wrapper example I noticed that the `that` object which is passed does not contain the updated data. I guess it is somehow related to the fact that its value is passed before parsing and the reference not being changed later. Changing the value to `ads` fixed this issue for me. I will have to take a deeper look at this problem and see what could be the correct fix for that (if you have any ideas/suggestions I will love to here).
Wrapper example:
http://demo.tremorvideo.com/proddev/vast/vast_wrapper_linear_2.xml
related to issue #2
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.