<Impression> tags are not extracted from a parent wrapper
Open
- Dominant language
- JavaScript
- Stars
- 58
- Forks
- 19
- PR merge metrics
- No merged PRs in 30d
Description
Causes the wrapping VAST provider to not be notified when the inner-vast impression is sent.
I think this is quite a simple fix and I will open a PR for that, but I just wanted to know where is the right place to do it.
No doubt it should inside the `VASTAd` function flow.
At first look I thought it should be where you copy tracking and creatives from parent (line 578).
But since `parentAd.impressions` is an array of string, you don't need to copy the same way you extract TrackingEvents (companions/nonlinears/...)
Any other thoughts?
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.