jonhoo / jonhoo/rust-imap

Does rust-imap parse things twice?

Open
#78 2 comments 0 reactions 0 assignees View on GitHub
help wanted performance tombstone
Dominant language
Rust
Stars
583
Forks
94
PR merge metrics
No merged PRs in 30d

Description

> It seems like a common pattern in the codebase is to use `run_command_and_read_response`, and then parse its output. However, `read_response` already fully parses the response, its just that the results of the parsing seems to be discarded https://github.com/mattnenterprise/rust-imap/blob/master/src/client.rs#L521.
>
> Assuming my reading of the code is correct, is there a reason it's laid out like this, as opposed to read_response returning a Vec of the parsed responses or similar?

See the original issue here: https://github.com/mattnenterprise/rust-imap/issues/78

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.